Add more info about a11y tests #76045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
Project:Accessibility
v8.0.0
release_note:skip
myasonik
requested review from
cjcenizal,
bmcconaghy,
bhavyarm,
rashmivkulkarni and
a team
bhavyarm
reviewed
Aug 26, 2020
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
rashmivkulkarni
approved these changes
Aug 27, 2020
gchaps
reviewed
Aug 27, 2020
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: gchaps <[email protected]>
@bhavyarm Do you think that would be helpful? I've seen that type of thing done for any type of test. |
|
@myasonik I keep explaining that process to folks who are adding new tests. Sometimes more than once. So yes? :) I will link this to meta issue on tests too. Thanks! |
|
@bhavyarm @rashminpawar I added the info y'all requested. What do you think? |
cjcenizal
approved these changes
Aug 27, 2020
|
btw, @myasonik - pinged the wrong Rashmi :-) Thanks for adding additional docs with examples |
|
@gchaps Could you look this over one more time? There's been a good amount added in the last few rounds and I think it's ready from a content perspective now. |
gchaps
reviewed
Aug 31, 2020
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/contributing/development-accessibility-tests.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: gchaps <[email protected]>
added 2 commits
September 3, 2020 12:39
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2020
…rok/new-patterns-component-use-array * 'master' of github.com:elastic/kibana: (75 commits) Remove legacy ui-apps-mixin (elastic#76604) remove unused test_utils (elastic#76528) [ML] Functional tests - add UI permission tests (elastic#76368) [APM] @ts-error -> @ts-expect-error (elastic#76492) [APM] Avoid negative offset for error marker on timeline (elastic#76638) [Reporting] rename interfaces to align with task manager integration (elastic#76716) Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220) Test reverting "Add plugin status API (elastic#75819)" (elastic#76707) [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595) [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399) [DOCS] Dashboard-first docs refresh (elastic#76194) Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344) [DOCS] Identifies cloud settings in reporting (elastic#76691) [Security Solution] Refactor timeline details to use search strategy (elastic#75591) es-archiver: Drop invalid index settings, support --query flag (elastic#76522) [DOCS] Identifies graph settings available on cloud (elastic#76661) Add more info about a11y tests (elastic#76045) [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943) [release notes] automatically retry on Github API 5xx errors (elastic#76447) [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392) ...
myasonik
pushed a commit
to myasonik/kibana
that referenced
this pull request
Sep 4, 2020
Co-authored-by: gchaps <[email protected]>
myasonik
pushed a commit
that referenced
this pull request
Sep 4, 2020
Co-authored-by: gchaps <[email protected]> Co-authored-by: gchaps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The accessibility tests look a little different from other functional tests so they raise a few eyebrows. Writing some more docs to better explain them.